• Sprint 102 (Jul 2023), Sprint 103 (Aug 2023), Sprint 104 (Sep 2023)
    • 2

      Remove support for TSDB 1.x from Zabbix server and frontend.

      This means bumping ZBX_TIMESCALE_MIN_VERSION to 20000 (or 20001) and removing all the code that is surrounded by ZBX_DB_TSDB_V1 from the server.

      The frontend must also remove any TSDB v1.x conditional code (e.g. isCompressed() in PostgresqlDbBackend).

      The docs must remove mentions of TSDB v1.x (if any, I didn’t find ones).

          [ZBXNEXT-8570] Remove TimescaleDB v1.x support

          dimir added a comment - - edited

          As I understand we drop support for versions <= 1.7.5 (Feb 16, 2021)

          dimir added a comment - - edited As I understand we drop support for versions <= 1.7.5 (Feb 16, 2021)

          dimir added a comment - - edited

          Talking about TimescaleDB versions that Zabbix supports, in 7.0 we will increase the absolute minimum supported version to 2.0.1 and recommended minimum to 2.10.0:

          Description Before After Comment
          Absolute minimum version ​1.5.0 ​2.0.1 Zabbix will not work with version less than that under no circumstances 
          Minimum version 2.0.1 2.10.0 Zabbix will work with version less than that if AllowUnsupportedDBVersions=1 (see here for more information)
          Maximum version 2.11.* 2.11.* Zabbix will work normally with version up to that (including)
          Too new version 2.12+ 2.12+ Zabbix will work with that version if AllowUnsupportedDBVersions=1

          dimir added a comment - - edited Talking about TimescaleDB versions that Zabbix supports, in 7.0 we will increase the absolute minimum supported version to 2.0.1 and recommended minimum to 2.10.0 : Description Before After Comment Absolute minimum version ​1.5.0 ​2.0.1 Zabbix will not work with version less than that under no circumstances  Minimum version 2.0.1 2.10.0 Zabbix will work with version less than that if AllowUnsupportedDBVersions=1 (see here for more information) Maximum version 2.11.* 2.11.* Zabbix will work normally with version up to that (including) Too new version 2.12+ 2.12+ Zabbix will work with that version if AllowUnsupportedDBVersions=1

          dimir added a comment - - edited

          Fixed in development branch for pre-7.0.

          Before this fix there were 2 separate functions:

          • for getting TSDB details
          • for checking TSDB details

          The latter function was reporting error when TSDB version was too old, while details were already collected (by the previous function). The first function was using different SQL queries when talking to v1 and v2 TSDB (for getting license and compressed chunk flags).

          ZBXNEXT-8570-before.pdf

          Since we removed support for v1 we must perform the version check first.

          This is why it was decided to combine those 2 functions and go one by one, getting a detail, reporting error if it isn't satisfactory.

          ZBXNEXT-8570-after.pdf

          One issue, I'm not sure if the function zbx_tsdb_get_license() that was moved from zbxdb to zbxdbhigh should be using zbx_db_*() or zbx_db_*_basic() functions.

          dimir added a comment - - edited Fixed in development branch for pre-7.0. Before this fix there were 2 separate functions: for getting TSDB details for checking TSDB details The latter function was reporting error when TSDB version was too old, while details were already collected (by the previous function). The first function was using different SQL queries when talking to v1 and v2 TSDB (for getting license and compressed chunk flags). ZBXNEXT-8570-before.pdf Since we removed support for v1 we must perform the version check first. This is why it was decided to combine those 2 functions and go one by one, getting a detail, reporting error if it isn't satisfactory. ZBXNEXT-8570-after.pdf One issue, I'm not sure if the function zbx_tsdb_get_license() that was moved from zbxdb to zbxdbhigh should be using zbx_db_*() or zbx_db_*_basic() functions.

          dimir added a comment - - edited

          Overview

          The TimescaleDB version requirements from Zabbix perspective where changed in this commit.

          Description Before this change After this change Comment
          Absolute minimum version ​1.5.0 ​2.0.1 Zabbix will not work with version less than that under no circumstances 
          Minimum version 2.0.1 2.10.0 Zabbix will work with version less than that if AllowUnsupportedDBVersions=1 (see here for more information)
          Maximum version 2.11.* 2.11.* Zabbix will work normally with version up to that (including)
          Too new version 2.12+ 2.12+ Zabbix will work with that version if AllowUnsupportedDBVersions=1

          Fixed in

          dimir added a comment - - edited Overview The TimescaleDB version requirements from Zabbix perspective where changed in this commit. Description Before this change After this change Comment Absolute minimum version ​1.5.0 ​2.0.1 Zabbix will not work with version less than that under no circumstances  Minimum version 2.0.1 2.10.0 Zabbix will work with version less than that if AllowUnsupportedDBVersions=1 (see here for more information) Maximum version 2.11.* 2.11.* Zabbix will work normally with version up to that (including) Too new version 2.12+ 2.12+ Zabbix will work with that version if AllowUnsupportedDBVersions=1 Fixed in 7.0.0alpha5 fb6ee28bdc5

            dimir dimir
            Kalimulin Alex Kalimulin
            Team I
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: